Files
swift-nio/Sources/NIOCore/IOData.swift
Johannes WeissandGitHub 0ee1657e8a Make NIOFileDescriptor/FileRegion/IOData Sendable & soft-deprecated (#2598)
Motivation:

`IOData` is a legacy but alas also core type that needs to be
`Sendable`. Before this PR however it can't be `Sendable` because it
holds a `FileRegion` which holds a `NIOFileDescriptor`. So let's make
all of these `Sendable` but let's also start the deprecation journey for
the following types:

- `IOData`, now soft-deprecated (no warnings) because on its reliance on
`FileRegion`
- `FileRegion`, now soft-deprecated (no warnings) because on its
reliance on `NIOFileHandle`
- `NIOFileHandle`, now soft-deprecated (warnings on the
`NIOFileHandle(descriptor:)` constructor but with a
`NIOFileHandle(_deprecatedTakingOwnershipOfDescriptor:)` alternative
- `NonBlockingFileIO`, now soft-deprecated (warnings on the `openFile`
functions (but with `_deprecated` alternatives) because of their
reliance on `NIOFileHandle)

Modification:

- Make `NIOFileDescriptor`, `FileRegion` and `IOData` `Sendable` by
tracking the fd number and the usage state in an atomic
- Enforce singular access by making the `withFileDescriptor { fd ... }`
function atomically exchange the fd number for a "I'm busy" sentinel
value
- Start deprecating `IOData`, `NIOFileHandle`, `NonBlockingFileIO`,
`FileRegion`

Result:
- `NIOFileDescriptor`, `FileRegion` and `IOData` can be `Sendable`
2024-11-25 16:05:30 +00:00

73 lines
2.6 KiB
Swift

//===----------------------------------------------------------------------===//
//
// This source file is part of the SwiftNIO open source project
//
// Copyright (c) 2017-2024 Apple Inc. and the SwiftNIO project authors
// Licensed under Apache License v2.0
//
// See LICENSE.txt for license information
// See CONTRIBUTORS.txt for the list of SwiftNIO project authors
//
// SPDX-License-Identifier: Apache-2.0
//
//===----------------------------------------------------------------------===//
/// `IOData` unifies standard SwiftNIO types that are raw bytes of data; currently `ByteBuffer` and `FileRegion`.
///
/// - warning: `IOData` is a legacy API, please avoid using it as much as possible.
///
/// Many `ChannelHandler`s receive or emit bytes and in most cases this can be either a `ByteBuffer` or a `FileRegion`
/// from disk. To still form a well-typed `ChannelPipeline` such handlers should receive and emit value of type `IOData`.
public enum IOData: Sendable {
/// A `ByteBuffer`.
case byteBuffer(ByteBuffer)
/// A `FileRegion`.
///
/// - warning: `IOData.fileRegion` is a legacy API, please avoid using it. It cannot work with TLS and `FileRegion`
/// and the underlying `NIOFileHandle` objects are very difficult to hold correctly.
///
/// Sending a `FileRegion` through the `ChannelPipeline` using `write` can be useful because some `Channel`s can
/// use `sendfile` to send a `FileRegion` more efficiently.
case fileRegion(FileRegion)
}
/// `IOData` objects are comparable just like the values they wrap.
extension IOData: Equatable {}
/// `IOData` provide a number of readable bytes.
extension IOData {
/// Returns the number of readable bytes in this `IOData`.
public var readableBytes: Int {
switch self {
case .byteBuffer(let buf):
return buf.readableBytes
case .fileRegion(let region):
return region.readableBytes
}
}
/// Move the readerIndex forward by `offset`.
public mutating func moveReaderIndex(forwardBy: Int) {
switch self {
case .byteBuffer(var buffer):
buffer.moveReaderIndex(forwardBy: forwardBy)
self = .byteBuffer(buffer)
case .fileRegion(var fileRegion):
fileRegion.moveReaderIndex(forwardBy: forwardBy)
self = .fileRegion(fileRegion)
}
}
}
extension IOData: CustomStringConvertible {
public var description: String {
switch self {
case .byteBuffer(let byteBuffer):
return "IOData { \(byteBuffer) }"
case .fileRegion(let fileRegion):
return "IOData { \(fileRegion) }"
}
}
}