swift-nio

mirror of https://github.com/apple/swift-nio.git synced 2026-05-20 20:30:36 +00:00

Files

T

History

Rick Newton-Rogers af3eee91b9 Benchmark diffs not being output on threshold regression

Motivation

* `check_benchmark_thresholds.sh` was updated to check for exit code 2
from `swift package benchmark thresholds check` to distinguish
threshold regression from build errors.
* It seems SwiftPM's `CommandPlugin` infrastructure always exits with code 1 when
`performCommand` throws, regardless of the error's raw value. So the
exit code is never 2, causing all regressions to fall through to the
`else` branch and be misreported as build errors, with no diff output.

Modifications

* Remove the `rc == 2` check and instead attempt `thresholds update`
for any non-zero `rc` from `thresholds check`.
* Use the result of `thresholds update` to distinguish regression
(success) from build error (failure).
* Remove `--exit-code` from `git diff` to prevent `set -uo pipefail`
from aborting the script before output is fully flushed.

Result

* Benchmark threshold regressions correctly output the `=== BEGIN DIFF
===` section again.
* Actual build errors are still correctly detected and reported.

2026-02-20 15:30:18 +00:00

analyze_performance_results.rb

Fix up the markdown output generated by scripts/analyze_performance_results.rb (#2651 )

2024-02-14 13:35:36 +00:00

check_benchmark_thresholds.sh

Benchmark diffs not being output on threshold regression

2026-02-20 15:30:18 +00:00

check-cxx-interop-compatibility.sh

Fix C++ interop CI script to work with changes in SwiftPM (#3510 )

2026-02-11 17:13:33 +00:00

check-matrix-job.ps1

check-matrix-job.sh should tolerate unset 6.1 vars (#3080 )