Motivation:
Swift 5.5 provides concurrency support on almost all platforms where it
is available. However, the Xcode 13 GM currently provides a macOS 11 SDK
with Swift 5.5, and the concurrency features are not available in that
SDK. As a result, NIO's concurrency features cause compile errors when
building the concurrency library on macOS using Xcode 13 GM.
Modifications:
- Only build the concurrency features when the concurrency library is
present.
Result:
We can build NIO using Xcode 13 GM.
- Use correct @available checks in `NIOAsyncAwaitDemo` (post WWDC '21)
- Remove `import _Concurrency` statements
Result:
- Cleaner imports
- static-stdlib linking works again on 5.5 (it does not if we explicitly `import _Concurrency`)
Co-authored-by: George Barnett <gbarnett@apple.com>
Motivation:
As we've largely completed our move to split out our core abstractions,
we now have an opportunity to clean up our dependencies and imports. We
should arrange for everything to only import NIO if it actually needs
it, and to correctly express dependencies on NIOCore and NIOEmbedded
where they exist.
We aren't yet splitting out tests that only test functionality in
NIOCore, that will follow in a separate patch.
Modifications:
- Fixed up imports
- Made sure our protocols only require NIOCore.
Result:
Better expression of dependencies.
Co-authored-by: George Barnett <gbarnett@apple.com>
Return `Task` from `EventLoopPromise.completeWithAsync(_:)` wrapper.
Motivation:
Bridging an `async` function into NIO is done by calling `completeWithAsync(_ body:)` on an `EventLoopPromise`. This spins up a `Task` and `await`s the result of the `async` closure that was passed in and uses the result to fulfil the promise with the value of the function, if it was successful, or with the error, if the function threw.
In some cases we may want to cancel this operation from the outside.
Modifications:
This patch adds a discardable return value to `EventLoopPromise.completeWithAsync(_:)` which is the `Task` it creates.
Result:
Users of `EventLoopPromise.completeWithAsync(_:)` are now able to explicitly cancel the `Task` that is being used to fulfil the promise.
* Add async implementation of EventLoopGroup.shutdownGracefully to _NIOConcurrency
Signed-off-by: Si Beaumont <beaumont@apple.com>
* fixup: Move elg lifecycle into async function in async demo
* fixup: Ensure continuation is run exactly once
* fixup: Shutdown event loop group in catch in async demo
Motivation:
The Swift concurrency features are only available in specific releases
of platforms where the Swift runtime ships with the platform. We need to
add availability guards to reflect that.
Modifications:
- Added appropriate availability guards for the async/await methods.
Result:
More likely to compile on Apple platforms.
Motivation:
The spelling of detach changed. This patch adopts the new spelling.
Modifications:
Changed detach to Task.detached.
Result:
5.5 should build again.
Motivation:
On Swift's main branch Task.runDetached has been renamed to detach.
Modifications:
Adopt the new spelling.
Result:
Compiles again on the main nightlies.
Motivation:
I accidentally put in the wrong check for A/A, thanks @theMomax for
spotting!
Modification:
Fix the check to be
```
#if compiler(>=5.4) // we cannot write this on one line with `&&` because Swift 5.0 doesn't like it...
#if compiler(>=5.4) && $AsyncAwait
```
which works on Swift 5.0+.
Result:
Correct checks.
Motivation:
The async/await proposal has entered the review phase, so we may want to
start looking into NIO with async/await.
Modifications:
- Add `EventLoopFuture.get() throws await`
- Add `ChannelOutboundInvoker` `async` methods
Result:
If async/await were actually implemented, you could use NIO together
with async/wait. So far, you can only compile your projects.
Fabian Fett
Cory Benfield
Si Beaumont
Si Beaumont
Tim Condon
Johannes Weiss
Adam Fowler