6 Commits

Author	SHA1	Message	Date
aryan-25	a1605a3303	Use explicit class name in all Self.[un]wrap{In}{Out}bound{In}{Out} calls (#3463) ... ### Motivation: Swift does not currently generic specialize static methods on final classes that have no parent classes when the method is implemented in a protocol. This means that calling such methods through `Self` will not involve a generic specialization, whereas using the explicit type name will. This pattern manifests in the `[un]wrap{In}{Out}bound{In}{Out}` static methods defined in the [`ChannelInboundHandler`](https://github.com/apple/swift-nio/blob/27146d484478b1bb0f150e848758f3a34ed9cbd0/Sources/NIOCore/TypeAssistedChannelHandler.swift#L60) and [`ChannelOutboundHandler`](https://github.com/apple/swift-nio/blob/27146d484478b1bb0f150e848758f3a34ed9cbd0/Sources/NIOCore/TypeAssistedChannelHandler.swift#L95) protocols and their use from all channel handler classes. As such, we should replace the `Self` part in all `Self.[un]wrap{In}{Out}bound{In}{Out}` calls with the explicit class name. ### Modifications: Replaced all `Self.[un]wrap{In}{Out}bound{In}{Out}` calls to use the explicit class name. ### Result: Eliminates unnecessary overhead.	2025-12-15 17:36:11 +00:00
George Barnett	a65e9735ac	Drop all server response parts after an invalid header (#3339) ... Motivation: NIOHTTPResponseHeadersValidator drops head/end response parts if they contain invalid header fields. If a head part is dropped and the server allows pipelining then the subsequent body/end part will reach the pipelining handler and result in an assertion failure in debug builds. In release builds, some parts may be incorrectly written out leading to protocol violations. Modifications: - Drop all response parts after an invalid response part Result: - Fewer bugs - Resolves #3326 Co-authored-by: Cory Benfield <lukasa@apple.com>	2025-08-12 09:33:24 +00:00
Franz Busch	c9756e1083	Adopt swift-format (#2794) ... * Apply formatting * Apply no block comments rule * Apply OmitExplicitReturns * Apple OnlyOneTrailingClosureArgument * Apply NoAssignmentInExpressions * Fix up DontRepeatTypeInStaticProperties lint errors * Apply `OrderedImports` * Apply `ReplaceForEachWithForLoop` * format file * Enable the formatting pipeline * Adopt `AmbiguousTrailingClosureOverload` * Fix license header * Fix format check * Fix `EndOfLineComment` * Fix CI * Adapt CI script to check if changes when running formatting * Separate lint and format into to steps * Fix format * Adopt `UseEarlyExits` * Revert "Adopt `UseEarlyExits`" This reverts commit d1ac5bbe12.	2024-07-19 11:48:17 +02:00
Johannes Weiss	7948ed2104	ChannelHandler: provide static (un)wrap(In|Out)bound(In|Out) (#2791)	2024-07-18 11:55:48 +01:00
David Nadoba	6720612111	Drop Swift 5.5 (#2406) ... * Drop Swift 5.5 * Use `swift-atomics` 1.1.0 with `Sendable` adoption	2023-04-17 08:40:35 +01:00
Cory Benfield	a16e2f54a2	Merge pull request from GHSA-7fj7-39wj-c64f ... Motivation HTTP headers are prevented from containing certain characters that can potentially affect parsing or interpretation. Inadequately policing this can lead to vulnerabilities in web applications, most notably HTTP Response Splitting. NIO was insufficiently policing the correctness of the header fields we emit in HTTP/1.1. We've therefore added a new handler that is automatically added to channel pipelines that will police the validity of header fields. For projects that are already running the validation themselves, this can be easily disabled. Note that by default NIO does not validate content length is correctly calculated, so applications can have their framing fall out of sync unless they appropriately calculate this themselves or use chunked transfer encoding. Modifications - Add thorough unit testing to confirm we will not emit invalid header fields. - Error if a user attempts to send an invalid header field. Result NIO applications are no longer vulnerable to response splitting by CRLF injection by default.	2022-09-27 13:09:52 +01:00